fix(clickhouse): strip virtual catalogs from executed queries and inserts - #6036
Open
mday-io wants to merge 1 commit into
Open
fix(clickhouse): strip virtual catalogs from executed queries and inserts#6036mday-io wants to merge 1 commit into
mday-io wants to merge 1 commit into
Conversation
…erts Signed-off-by: mday-io <mdaytn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
database.tablenames. Direct queries, including audit queries and INSERT post-statements used for initial history loads, bypasscreate_viewnormalization. Without this fix, otherwise valid SQL reaches ClickHouse with unsupported catalog-qualified table and column names and can fail during execution. Fixing the adapter avoids requiring each project to add its own rendering workaround.INSERT INTO __gw__.db.target SELECT ... FROM __gw__.db.sourcenow reaches ClickHouse usingdb.targetanddb.source. Direct execution bypasses the view-creation handling added in fix(clickhouse): strip virtual catalog from view sources #5940; fix(clickhouse): initialize virtual catalog for cleanup #5941 addresses cleanup initialization separately.Test Plan
make stylepasses: Ruff, formatting, mypy, and migration checks.make fast-testpasses: 2,625 tests passed and four skipped; all isolated, registry-isolation, and dialect-isolation suites passed.git diff --checkpasses.